enhance: don't run travis-CI for only document change #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
- Coverage 68.8% 68.72% -0.09%
==========================================
Files 272 272
Lines 18175 18175
==========================================
- Hits 12506 12491 -15
- Misses 4253 4264 +11
- Partials 1416 1420 +4
|
fuweid
changed the title
fuweid
changed the title
allencloud
reviewed
Oct 25, 2018
INSTALLATION.md
Outdated
| @@ -189,7 +189,7 @@ This guide provides step by step instructions to deploy PouchContainer on bare m | |||
| As a developer, you may need to build and test PouchContainer binaries via source code. To build pouchd which is so-called "PouchContainer Daemon" and pouch which is so-called "PouchContainer CLI", the following build system dependencies are required: | |||
|
|
|||
| * Linux Kernel 3.10+ | |||
There was a problem hiding this comment.
I think we need to update this part, this part is never accurate.
CentOS, 3.10-327
Ubuntu, 4.0?
Could someone could help me to make it clear? @alibaba/pouch
There was a problem hiding this comment.
I will do that. @allencloud
save resource and time. Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
changed the title
|
LGTM merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save resource and time.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews